Return 'static' instead of 'self' in static returning methods

thecodingmachine / tdbm

The Database Machine is a PHP ORM that requires no configuration. The object model is deduced from the database model.

https://thecodingmachine.github.io/tdbm/

119 stars 27 forks source link

Open donjajo opened 6 months ago

donjajo commented 6 months ago

Extending classes need to return itself

homersimpsons commented 6 months ago

LGTM, thank you!

homersimpsons commented 6 months ago

Actually it looks like this is not available for php 7.4. It is available since PHP8.0.

@moufmouf are you okay to upgrade the minimum php version to PHP8.0?

moufmouf commented 4 months ago

@homersimpsons Definitely ok if you tag a new minor (or major) release (don't do this in a patch release)

homersimpsons commented 4 months ago

@donjajo Can you upgrade the php requirement in composer.json?