Fix #42, #46 and #47 - Githubissues

thecodrr / fdir

⚡ The fastest directory crawler & globbing library for NodeJS. Crawls 1m files in < 1s

https://thecodrr.github.io/fdir/

MIT License

1.51k stars 58 forks source link

Fix #42, #46 and #47 #45

Closed papb closed 3 years ago

papb commented 3 years ago

Hello, this PR fixes a few issues!

Fixes #42
- I used '\0' instead of '||' because \0 is the only character that cannot ever appear in a file path, cross-platform, so no one should ever use that in any glob pattern, while '||' could in theory appear in a glob pattern, possibly.
Fixes #47
Closes #46

papb commented 3 years ago

And thanks for this great package. I am sorry for not adding any tests, I really don't have time for that right now. I will be using my fork in the mean time. But at least I can ensure you that by using my fork the async issue I mentioned disappeared.

If anyone else also wants to, you can just do:

# npm
npm install --save https://github.com/papb/fdir/tarball/5c2f71373b6a1e08637b4dcfcb8ae1d9ae298ad3

# yarn
yarn add https://github.com/papb/fdir/tarball/5c2f71373b6a1e08637b4dcfcb8ae1d9ae298ad3

papb commented 3 years ago

Update: added more commits to fix #46 as well.

thecodrr commented 3 years ago

Hey @papb

Thank you so much for taking the time : )

So sorry for the late response, I'll be taking a look into the PR shortly. I need to run benchmarks and see how the concurrency issue is affecting the performance.

Will be leaving a review in a bit.