search

thecodrr / fdir

⚡ The fastest directory crawler & globbing library for NodeJS. Crawls 1m files in < 1s
https://thecodrr.github.io/fdir/
MIT License
1.51k stars 58 forks source link

Add picomatch in peerDependencies #76

Closed kyleknighted closed 2 years ago

kyleknighted commented 2 years ago

This will allow adopting libraries use picomatch without error and without it being a required dependency to install.

thecodrr commented 2 years ago

Thank you so much for your contribution.

IanVS commented 2 years ago

@thecodrr do you think we could get a release with this? As far as I know, this should enable yarn pnp support for fdir, although I think we should also add an optional indication to the peer dependency, since it's technically not required unless using globs. I can put up a PR for that, but if this were just released as-is, it would unblock me from using fdir in storybook.