search

thecodrr / fdir

⚡ The fastest directory crawler & globbing library for NodeJS. Crawls 1m files in < 1s
https://thecodrr.github.io/fdir/
MIT License
1.51k stars 58 forks source link

Make picomatch an optional dependency #80

Closed IanVS closed 2 years ago

IanVS commented 2 years ago

Building off of https://github.com/thecodrr/fdir/pull/76, this makes picomatch an optional peer dependency, to avoid it from being automatically installed by some package managers, or throwing warnings in others.

@thecodrr I'd love if you could take a look at this and hopefully merge and release a new version soon, so it can unblock me on https://github.com/storybookjs/storybook/pull/19297 in adding this library to Storybook.

IanVS commented 2 years ago

Thanks for merging! Any chance you can cut a new release soon?

thecodrr commented 2 years ago

Yes, I am on it.

IanVS commented 2 years ago

Hi, I'm blocked on getting this package into storybook until this PR is released. It looks like maybe you're working on converting to typescript, but perhaps you could release a patch version right now, and get new work into a subsequent release? That would really help us out, and it would also fix this package for anyone else using yarn pnp or pnpm.

thecodrr commented 2 years ago

Yes, that's what I am going to do. Typescript will take a bit of time.

thecodrr commented 2 years ago

Done @IanVS

IanVS commented 2 years ago

Thanks @thecodrr! I've updated my Storybook PR 🤞.

thecodrr commented 2 years ago

Thank you for using fdir!