thecodrr / fdir

âš¡ The fastest directory crawler & globbing library for NodeJS. Crawls 1m files in < 1s
https://thecodrr.github.io/fdir/
MIT License
1.46k stars 51 forks source link

Add `fs.readdir` with `{ recursive: true }` to benchmarks #95

Closed isker closed 9 months ago

isker commented 10 months ago

As of node 20.1.0 and 18.17.0, there is now a recursive implementation of fs.readdirSync, fs.promises.readdir, etc: https://nodejs.org/api/fs.html#fspromisesreaddirpath-options. It would be good to have fdir benchmarked against it.

It's trivial to add, and I did so locally (don't worry, the performance of these functions is quite poor 🌞), but I figure there's no point in opening a PR as my machine is quite different from the one used in the existing BENCHMARKS.md.

thecodrr commented 10 months ago

@isker would you be williing to open a PR for it?

isker commented 10 months ago

Well, like I said, I could add the benchmark, but I'd probably need you to actually run it? You have the machine that produced BENCHMARKS.md, right?

thecodrr commented 10 months ago

@isker oh right. Sorry morning brain is a little slow 😆 . I will add this to the benchmarks soon.

thecodrr commented 9 months ago

Done.

isker commented 9 months ago

Thank you!