Update package.json and build.sh

thecommons-urbit / chess

Distribution repo for Urbit Chess app

Other

24 stars 8 forks source link

Update package.json and build.sh #126

Closed ashelkovnykov closed 1 year ago

ashelkovnykov commented 1 year ago

Missed the version in package.json when bumping to 0.9.3
Added DOCKER_BUILDKIT workaround to build.sh so that build works for MacOS users hitting this issue

ashelkovnykov commented 1 year ago

@bonbud-macryg Good idea - I'll add it as a separate commit in this PR. We should absolutely make sure that we have a working build path for MacOS users.

ashelkovnykov commented 1 year ago

@bonbud-macryg It's specifically a MacOS issue, but not just on your end. Like you say, there's no cost to disabling the Docker Buildkit - it's just the package they use for building an image from a Dockerfile in the latest version of Docker. If you run with it disabled, it gives a warning that running without Buildkit is deprecated, so the next version of Docker will remove the old build system. However, I'd hope that by then they fix an issue blocking building on MacOS...