search

thecommons-urbit / chess

Distribution repo for Urbit Chess app
Other
24 stars 8 forks source link

Fix minor visual bug #127

Closed ashelkovnykov closed 1 year ago

ashelkovnykov commented 1 year ago

Before this fix, any time an update would come through while a user was browsing an old board state it would reset the board. Now, the board is only reset to the current state when an undo request is accepted or when a new move is made.

ashelkovnykov commented 1 year ago

@bonbud-macryg I agree - I was thinking of heading into v1 like this and waiting for the community to share feedback, on whether this is annoying or not. Also wanted to do a live sit-down with some of the Tlon designers and get their feedback.

ashelkovnykov commented 1 year ago

118 Had a bug in it which would cause this, though it was addressed and tested successfully. I tested both this commit and #118 for several moves without issue. Standby, I'll rebase onto develop and re-test both develop and this PR.

ashelkovnykov commented 1 year ago

Just added a comment to #129 - relevant bit is that I tested this PR on completely new fake ships and didn't encounter any issues.