thecosmicfrog / LuasataGlance

Android Wear and mobile app providing real-time tram stop information for Dublin's Luas light rail service.
https://play.google.com/store/apps/details?id=org.thecosmicfrog.luasataglance
GNU General Public License v3.0
21 stars 5 forks source link

""Favourite" state not remembered after navigation #19

Open marcasoduinn opened 5 years ago

marcasoduinn commented 5 years ago

The "Favourite" choice/state is not remembered after any navigation, both intra- and inter-app. For example, moving to the map and back within the app; moving to another phone app and back.

Is that a feature or a bug?

thecosmicfrog commented 5 years ago

Hi @marcasoduinn,

Thanks for the report. Do you mind providing more details on what you mean here? For example, the steps you're taking and "What should happen"/"What actually happens"?

By any chance, do you have a "Default stop" set in the app settings? This overrides whatever your last stop selection was. Just checking!

Many thanks, Aaron

marcasoduinn commented 5 years ago

Hi Aaron, I think it is the "default stop" override that is what make this issue a feature.

Yes, i have a default stop (Leopardstown Valley) but i have also a set of favourites (Glencairn and Stephen's Green). Coming home from work, I check Stephen's Green, so i choose that from my favourites. 7 minutes to the next tram? Great, a bit of time, no rush, I'll see what the latest headlines are on the Irish Times website... the Thai youngsters al got out safely... time of tram now? What, DUE? ... Oh, wait, because i navigated away, LaaG has gone back to Leopardstown Valley (default stop override, now that i know!)... choose Stephen's Green again from favourites... 4 minutes, phew!

It's very handy to have a default stop and a set of favourites, but it's a bit disconcerting that, having chosen a favourite, the app reverts to the default stop after any navigation away from the time table page.

So the first question is, is this a feature or a bug? At the very least, one to think about, and not rush to judgement on! Marcas

On Déar 12 Iúil 2018 00:15 Aaron Hastings notifications@github.com wrote:

Hi @marcasoduinn https://github.com/marcasoduinn,

Thanks for the report. Do you mind providing more details on what you mean here? For example, the steps you're taking and "What should happen"/"What actually happens"?

By any chance, do you have a "Default stop" set in the app settings? This overrides whatever your last stop selection was. Just checking!

Many thanks, Aaron

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thecosmicfrog/LuasataGlance/issues/19#issuecomment-404339443, or mute the thread https://github.com/notifications/unsubscribe-auth/AnJWh-7gHkg9zz1RBEKF0FiaAlLmZvTwks5uFocVgaJpZM4VLccw .

marcasoduinn commented 5 years ago

Jaysus... "that is what make" --> "which makes".