search

thecosmicfrog / LuasataGlance

Android Wear and mobile app providing real-time tram stop information for Dublin's Luas light rail service.
https://play.google.com/store/apps/details?id=org.thecosmicfrog.luasataglance
GNU General Public License v3.0
21 stars 5 forks source link

Pull request from marcasoduinn fork to base fork (thecosmicfrog) #20

Closed marcasoduinn closed 6 years ago

marcasoduinn commented 6 years ago

Initiating pull reqest from my fork to the base fork.

You can see some discussion of the changes here: https://github.com/marcasoduinn/LuasataGlance/wiki

The "fares_note" needs two further edits. If I edit the file now in my fork:master, will they be part of this pull request?

thecosmicfrog commented 6 years ago

Looks good @marcasoduinn! Sorry for the delay in responding.

I've merged these changes now. If you still have other changes to make (fares?), no sweat - you can create another PR and I'll review/merge it once it's in.

The next release of the app should be a bugfix release, as well updates to the various underlying libraries, so your changes will pop up once that happens.

Thanks a million once again - it's a huge benefit to the project and a pleasure to accept contributions!

thecosmicfrog commented 6 years ago

And a nice little perk for you - the merge commit for your changes is commit #300! :)

screenshot from 2018-08-08 23-20-51

marcasoduinn commented 6 years ago

Hi Aaron, that's great to hear, ill look out for the app being updated on my phone.

I have a couple of small edits for the Mobile app, but I've also updated the Wear version in line with the Mobile, which I'll include in my next pull request.

I'm happy with the changes for release, but i haven't reviewed them yet with an Irish speaker (I'm not a native speaker). When i get that done, I'll let you know also.

Marcas

On Céad 8 Lún 2018 23:22 Aaron Hastings notifications@github.com wrote:

And a nice little perk for you - the merge commit for your changes is commit #300! :)

[image: screenshot from 2018-08-08 23-20-51] https://user-images.githubusercontent.com/571746/43867615-d5b48504-9b61-11e8-81b5-26cfb55aae42.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thecosmicfrog/LuasataGlance/pull/20#issuecomment-411572112, or mute the thread https://github.com/notifications/unsubscribe-auth/AnJWh6QpwYOIFB8zlROxWKy2hjId0mqWks5uO2SJgaJpZM4Vsls8 .