thecsw / gana

Generic library for my go programs
Apache License 2.0
3 stars 1 forks source link

Add SkipRunes, DropRunes #6

Closed matthewsanetra closed 2 years ago

matthewsanetra commented 2 years ago

Per discussion in #3, I've implemented SkipRunes, DropRunes.

I have also made the following changes:

thecsw commented 2 years ago

@matthewsanetra Regarding point 6, when we take uint as an input parameter, it is aliased to uint32, I believe. To avoid any superfluous casting on the user's side, what do you think about using constraints.Unsigned, which includes all uint flavors?

matthewsanetra commented 2 years ago

what do you think about using constraints.Unsigned, which includes all uint flavors?

Very good idea! Changing now.

thecsw commented 2 years ago

Woohoo! Tests passed. Merging.

@matthewsanetra thanks for the updates! Great stuff 🚀