thecyberworld / TheCyberHUB

Welcome to TheCyberHUB, a community-driven platform for hackers, cybersecurity enthusiasts, and IT professionals. Our platform provides a variety of free resources, including Capture The Flag (CTF) challenges, courses, blogs, forums, and much more.
http://www.thecyberhub.org/
MIT License
144 stars 164 forks source link

Refreshed style changes from reviewed comments on feeds page, #857 #862

Closed alvarotorrestx closed 3 weeks ago

alvarotorrestx commented 3 months ago

Fixes Issue

Closes #857

Changes proposed

Screenshots

https://github.com/thecyberworld/TheCyberHUB/assets/79110517/de4b1086-af6e-4586-b611-54b1bbb7f89c

Note to reviewers

Code of Conduct

Check List (Check all the applicable boxes)


You can also join our Discord community. Feel free to check out other cool repositories of the Thecyberworld. Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).

ArkadiK94 commented 3 months ago

here make the search bar half of the current wide

image


Should I start a fix on resizing them? (I'm waiting for your review also to work on this)

What do you mean? could you screenshot an example?

@alvarotorrestx

alvarotorrestx commented 3 months ago

Here is an example, this is on smaller screens. In the screenshot I am turning off the overflow:hidden to show the difference. image image

The same happens at breakpoint w > 950: image image

@ArkadiK94

ArkadiK94 commented 3 months ago

@alvarotorrestx ok, thanks I understand now, yes please fix it. Add word-wrap and so on.

alvarotorrestx commented 3 months ago

Will do @ArkadiK94

alvarotorrestx commented 2 months ago

Still working on it, slight delay but should have something today.

kabir0x23 commented 2 months ago

@alvarotorrestx , Hi

can u check if everything is fine on Explorer as well, we are using the same components over there for feeds

and little bit of conflicts are coming can u give a look over there as well

thanks

alvarotorrestx commented 2 months ago

@alvarotorrestx , Hi

can u check if everything is fine on Explorer as well, we are using the same components over there for feeds

and little bit of conflicts are coming can u give a look over there as well

thanks

Yes, that was my original plan to make them both responsive. So I will work on both! πŸ‘Œ

alvarotorrestx commented 2 months ago

I wanted an opinion as well before I were to implement it as well for the desktop layout of the Feeds & Explore pages...

Currently Feeds is like this: image

Explore is like this: image

Wouldn't it be ideal to possibly swap Feeds reverse? The search bar on the left and the feed on the right? Or vice versa, Explore reversed?

This will help keep a consistent look especially as you add more to the website.

What are your thoughts so I can implement? @ArkadiK94 @kabir0x23

ArkadiK94 commented 2 months ago

@alvarotorrestx In my opinion, it is a great I idea. I would prefer that you will swap inside the Explore page. @kabir0x23 what do you think?

kabir0x23 commented 2 months ago

yes, we can try with a look

alvarotorrestx commented 2 months ago

This would be the updated feeds: image

This would be the fixed desktop explore page: image

Resolved the overflow around this width image

Working on resolving overflows for this along with the below Feeds on the Explore page and the Feeds page: image image image

alvarotorrestx commented 2 months ago

Pending commit will be coming, I have saved my progress to work on other device continuously.

kabir0x23 commented 2 months ago

Hi, can you try to move it sidebar to right side?

alvarotorrestx commented 2 months ago

Sorry, so you want them like this?

image

image

kabir0x23 commented 2 months ago

looks good

ArkadiK94 commented 2 months ago

@alvarotorrestx hi, any update?

alvarotorrestx commented 2 months ago

@ArkadiK94 Hey there, I'm so sorry. I've fallen behind on a lot of my open source work because I've been helping my mother who just recently had surgery. If you'd like I can submit my most recent updates that I had when I get on my home computer. I can try to get it completed this week or you can re-assign. I completely understand.

ArkadiK94 commented 2 months ago

@alvarotorrestx everything is ok, don't worry. I hope your mother will feel better. It is up to you, if you want you can submit what you already did and we will re-assign this issue or you can continue working on it. What do you prefer?

alvarotorrestx commented 2 months ago

@ArkadiK94 Thanks, I appreciate that. Yes, I will submit what I've done later today and you can re-assign. That way I don't keep you waiting. I will take a look at other issues hopefully soon to help continue to contribute. πŸ‘

alvarotorrestx commented 2 months ago

@ArkadiK94 submitted what I had, thank you!