Closed alvarotorrestx closed 3 weeks ago
Should I start a fix on resizing them? (I'm waiting for your review also to work on this)
What do you mean? could you screenshot an example?
@alvarotorrestx
Here is an example, this is on smaller screens. In the screenshot I am turning off the overflow:hidden to show the difference.
The same happens at breakpoint w > 950:
@ArkadiK94
@alvarotorrestx ok, thanks I understand now, yes please fix it. Add word-wrap and so on.
Will do @ArkadiK94
Still working on it, slight delay but should have something today.
@alvarotorrestx , Hi
can u check if everything is fine on Explorer as well, we are using the same components over there for feeds
and little bit of conflicts are coming can u give a look over there as well
thanks
@alvarotorrestx , Hi
can u check if everything is fine on Explorer as well, we are using the same components over there for feeds
and little bit of conflicts are coming can u give a look over there as well
thanks
Yes, that was my original plan to make them both responsive. So I will work on both! π
I wanted an opinion as well before I were to implement it as well for the desktop layout of the Feeds & Explore pages...
Currently Feeds is like this:
Explore is like this:
Wouldn't it be ideal to possibly swap Feeds reverse? The search bar on the left and the feed on the right? Or vice versa, Explore reversed?
This will help keep a consistent look especially as you add more to the website.
What are your thoughts so I can implement? @ArkadiK94 @kabir0x23
@alvarotorrestx In my opinion, it is a great I idea. I would prefer that you will swap inside the Explore page. @kabir0x23 what do you think?
yes, we can try with a look
This would be the updated feeds:
This would be the fixed desktop explore page:
Resolved the overflow around this width
Working on resolving overflows for this along with the below Feeds on the Explore page and the Feeds page:
Pending commit will be coming, I have saved my progress to work on other device continuously.
Hi, can you try to move it sidebar to right side?
Sorry, so you want them like this?
looks good
@alvarotorrestx hi, any update?
@ArkadiK94 Hey there, I'm so sorry. I've fallen behind on a lot of my open source work because I've been helping my mother who just recently had surgery. If you'd like I can submit my most recent updates that I had when I get on my home computer. I can try to get it completed this week or you can re-assign. I completely understand.
@alvarotorrestx everything is ok, don't worry. I hope your mother will feel better. It is up to you, if you want you can submit what you already did and we will re-assign this issue or you can continue working on it. What do you prefer?
@ArkadiK94 Thanks, I appreciate that. Yes, I will submit what I've done later today and you can re-assign. That way I don't keep you waiting. I will take a look at other issues hopefully soon to help continue to contribute. π
@ArkadiK94 submitted what I had, thank you!
Fixes Issue
Closes #857
Changes proposed
Screenshots
https://github.com/thecyberworld/TheCyberHUB/assets/79110517/de4b1086-af6e-4586-b611-54b1bbb7f89c
Note to reviewers
Code of Conduct
Check List (Check all the applicable boxes)
You can also join our Discord community. Feel free to check out other cool repositories of the Thecyberworld. Join the Thecyberworld GitHub Organisation by raising an issue (you will be sent an invitation).