Deprecated code in magic.php needs testing

thecyman / pulsecms-tracking

Tracking updates, requests and bugs for Pulse

6 stars 3 forks source link

Deprecated code in magic.php needs testing #144

Open ghost opened 4 years ago

ghost commented 4 years ago

There is deprecated code in /admin/inc/magic.php. This file is no longer needed:

get_magic_quotes_gpc()

image_2020_07_06T05_18_14_838Z

ghost commented 4 years ago

debug_info_douwe.zip

Logs for this issue

junction10 commented 4 years ago

I've spotted this too, noted it here: https://forum.pulsecms.com/t/get-magic-quotes-gpc-php-5-4/1890/3

I was told that it's ok to use a higher version of PHP (I already am, I was just noting that the code was deprecated in version 5.4 - but the point is, the deprecated code shouldn't be in Pulse when the whole product requires a version of PHP that doesn't support the code it uses... What is the code going to break if it doesn't work due to being deprecated?

thecyman commented 4 years ago

I've added this to the next build to be addressed. Thanks for all your help!