search

thedarkcolour / KotlinForForge

Makes Kotlin forge-friendly.
GNU Lesser General Public License v2.1
187 stars 26 forks source link

NeoForge renamed "mods.toml" to "neoforge.mods.toml", so the NeoForge version doesn't load anymore #95

Closed KP2048 closed 5 months ago

KP2048 commented 5 months ago

When NeoForge updated to 1.20.5, they renamed the toml file from mods.toml to neoforge.mods.toml

thedarkcolour commented 5 months ago

I will keep this in mind when updating; more has changed too and many breaking changes will require KFF 5.x

KP2048 commented 5 months ago

I suppose while it is a minor version technically speaking, most of the changes were done under the hood as opposed to gameplay mechanics. If there are enough changes to warrant a major version bump it would make total sense. If you would like help with it, I'm totally open to help. I primarily write my mods in Kotlin, and I use Architectury to share code between fabric/NeoForge, so you could say I'm invested in this project's success.

thedarkcolour commented 5 months ago

The breaking changes that affect Kotlin for Forge come from NeoForge, not Minecraft

thedarkcolour commented 5 months ago

I am working on fixing things right now.

KP2048 commented 5 months ago

The breaking changes that affect Kotlin for Forge come from NeoForge, not Minecraft

While that is true, those changes probably stemmed from the changes to the game, also java 21 now

thedarkcolour commented 5 months ago

Nope. NeoForge just took this as an opportunity to do some cleanup and refactoring.

KP2048 commented 5 months ago

Fair enough I guess.