API throws unprocessed Use of uninitialized value $id error

netsensei commented 7 years ago

The API.pm module throws up this error. Needs to be fixed / made more human understandable what went wrong.

Use of uninitialized value $id in sprintf at /Users/matthiasvandermaesen/.plenv/versions/5.22.0/lib/perl5/site_perl/5.22.0/Catmandu/Store/Datahub/API.pm line 112.
Odd number of elements in anonymous hash at /Users/matthiasvandermaesen/.plenv/versions/5.22.0/lib/perl5/site_perl/5.22.0/Catmandu/Store/Datahub/API.pm line 128.
Use of uninitialized value in concatenation (.) or string at /Users/matthiasvandermaesen/.plenv/versions/5.22.0/lib/perl5/site_perl/5.22.0/Catmandu/Error.pm line 172.
Use of uninitialized value in concatenation (.) or string at /Users/matthiasvandermaesen/.plenv/versions/5.22.0/lib/perl5/site_perl/5.22.0/Catmandu/Error.pm line 173.

netsensei commented 7 years ago

Apparently this has to do when $id isn't passed to the method calls.

netsensei commented 7 years ago

Commit does not fix issue:

Implementing "update" in the add method was a deliberate design choice.

Catmandu Bag's don't have an 'update' method. Only adding and deleting Last week, I've made the decision to make the flow RFC 2162 sec 9.6 PUT compliant. PUT proposes creation AND updating of existing records IF the client always determines the resource ID instead of the server. Since we pass a Persistent ID with our records, we can implement this here.
A Catmandu::Bag object only allows passing $data objects to it's method ( i.e. add($data) and not add($data, $id) as originally coded ) Datahub::Store contained LIDO specific logic > trying to fetch the LIDO specific 'id' from the passed $data object. I moved this code from the generic Datahub::Store module to the specific Datahub-Factory-Arthub module. (See: newly added Arthub module)
Hence the requirement to pass a $data object with two distinct fields: (a) the data itself (b) the identifier.
I've updated the Datahub code to be RFC 2162 sec 9.6 PUT compliant too. Datahub::Store uses the $id as a token in the Datahub resource URL to which it makes a PUT call (like http://datahub.box/api/v1/data/http://myid/) and $data is send as the HTTP body.

So, this could should be reverted since it's a major architectural change which really breaks the entire flow.

What we really want is some kind of failure if the $id is present or not in the API update method. Either a Catmandu Exception or False.

thedatahub / Catmandu-Store-Datahub

API throws unprocessed Use of uninitialized value $id error #3