In Datahub::Factory::Fixer, replace ->fixer->fix with ->fix

thedatahub / Datahub-Factory

Datahub::Factory - Transport metadata between Collection Management Systems and the Datahub

Other

2 stars 4 forks source link

In Datahub::Factory::Fixer, replace ->fixer->fix with ->fix #27

Open pieterdp opened 7 years ago

pieterdp commented 7 years ago

Currently, all fixers (Datahub::Factory::Fixer and children) have the attribute fixer, which in itself has the method fix that is used to execute the Fix. It would be cleaner and more in line with the rest of the application if Datahub::Factory::Fixer and children have the method fix, so we can replace

$fixer->fixer->fix($item);

with

$fixer->fix($item);

morrme commented 7 years ago

I'd like to help.

pieterdp commented 7 years ago

Hi,

Thanks for offering to help! The solution to this problem is, I think, twofold:

Update Fix.pm to expose the method ->fix() of the fixer attribute. See Datahub.pm for an example. For more information on how fixes work, see Catmandu::Fix.
Update transport.pm so it uses ->fix() instead of ->fixer->fix().

You can simply clone the master branch (we have no dev branch) and open a pull request.

Should you have any more questions, don't hesitate to ask them.

morrme commented 7 years ago

I need to wrap this up ....will update soon!