Review exception handling in transport command

thedatahub / Datahub-Factory

Datahub::Factory - Transport metadata between Collection Management Systems and the Datahub

Other

2 stars 4 forks source link

Review exception handling in transport command #36

Open netsensei opened 7 years ago

netsensei commented 7 years ago

The Datahub::Factory::Command::transport module currently contains several nested try...catch blocks, including different ways in which errors are caught, processed or bubble up to an ancestor catch.

netsensei commented 7 years ago

Todo:

Add extra exception classes in an Error.pm module.
Review the try catch blocks we have right now throughout the app.
Review how errors are logged throughout the app. Bubble up exceptions to the least amount of catch blocks we can get away with, instead of spreading catch blocks throughout the app.

netsensei commented 7 years ago

When an error bubbles up, always mention the ID of the breaking record.