search

thedataincubator / forecaster

3 stars 1 forks source link

Dockerize application #17

Open derekmhh opened 6 years ago

derekmhh commented 6 years ago

Dockerize application to deploy by Docker instead of Conda Buildpack

derekmhh commented 6 years ago

I'm not entirely sure the encrypted api_key passthrough in .travis.yml for Heroku registry login is implemented correctly. Please double check.

derekmhh commented 6 years ago

Pull request accidentally closed. Reopen.

ZachGlassman commented 6 years ago

I'm happy to have a testing and production Dockerfile, but I would rather we don't duplicate code. The testing environment should be the same as the prod Dockerfile with some extra bits, so you might want to use the prod Dockerfile as a base.