search

thedataincubator / forecaster

3 stars 1 forks source link

Bokeh Version #7

Open ZachGlassman opened 6 years ago

ZachGlassman commented 6 years ago

The default version of Bokeh seems rather old. We should update that.

sdorsher commented 6 years ago

Set bokeh=0.13.0.

ZachGlassman commented 6 years ago

would you like to do this?

sdorsher commented 6 years ago

Sorry, I was following your example. I did do this I think. Did I do it wrong?

Steven

On Jun 20, 2018, at 5:51 PM, ZachGlassman notifications@github.com wrote:

would you like to do this?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/thedataincubator/forecaster/issues/7#issuecomment-398922243, or mute the thread https://github.com/notifications/unsubscribe-auth/AKXkEX18I9Md9l8MhUTBJ5MD-xBP6i8Vks5t-tHlgaJpZM4UuY5L.

ZachGlassman commented 6 years ago

You will need to make a branch in this repo and open a pull request against master

ZachGlassman commented 6 years ago

I think you have forked the repo and made a branch there. This is a fine way to do things in general, but for this project, we will be making branches within this repo. If you simply switch the remotes you can push a branch here.

sdorsher commented 6 years ago

I think there may also be a flaw in the way I handled bokeh versioning in conda. When you do conda search, this is the latest version. But conda install bokeh --revision 0.13.0 does not work, and conda install bokeh0.13.0 does not work, and conda install bokeh0.13 does not work, and I'm not sure conda install bokeh0 is what we're looking for to update our version.

The reason I chose the formatting I did as a placeholder is that it is possible to write some kind of script to parse this file. But a bash script does not handle it easily. Neither does cat conda_requirements.txt | conda install, because line by line parsing is needed. So-- please modify, and update instructions, if you know a better way.

ZachGlassman commented 6 years ago

please open a pull request so that I can comment upon it. The only thing you should need to do is modify the conda-requirements file and the app.py file. One other note, conda has its own repos which may not have the absolute latest version of every package, I think the move to bokeh 0.13 is very recent.

sdorsher commented 6 years ago

conda install bokeh=0.13.0 definitely works. conda install conda-requirements.txt with bokeh=0.13.0 definitely does not work. I am still trying to figure this out.