thedaviddias / Front-End-Checklist

🗂 The perfect Front-End Checklist for modern websites and meticulous developers
https://frontendchecklist.io
Creative Commons Zero v1.0 Universal
69.01k stars 6.45k forks source link

fixed typo #454

Closed schbz closed 3 years ago

schbz commented 3 years ago

changed "rich restults test" to "rich results test"

Fixes: #

🚨 Please review the guidelines for contributing and our code of conduct to this repository. 🚨 Please complete these steps and check these boxes (by putting an x inside the brackets) before filing your PR:

Short description of what this resolves:

the word "results" was misspelled.

Proposed changes:

just a simple typo correction. Everything else looks perfect.

-

👍 Thank you!

k1nxx commented 3 years ago

no one cares about a typo :) Thanks

schbz commented 3 years ago

no one cares about a typo :) Thanks

True, I've got to start somewhere though, lol

k1nxx commented 3 years ago

no one cares about a typo :) Thanks

True, I've got to start somewhere though, lol

You start by helping people, not fixing a typo. Btw if your reading this you prob read typo's like they are correct. Sad to see people get credit for fixing a typo.

schbz commented 3 years ago

there's a big dif between typos and abbrv. if you don't want to give me credit then don't. I was just experimenting with the pull request system.

k1nxx commented 3 years ago

Experiment on your own repo's.

k1nxx commented 3 years ago

I'm not trying to be rude. I'm just saying "Stop opening a pull for a simple typo" That's all.

Regards, Stay safe, Ryan s.

schbz commented 3 years ago

message received. Now I know. have a nice day.

k1nxx commented 3 years ago

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

schbz commented 3 years ago

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

No worries. I wouldn't want people spamming my repos either. For future reference, is it a good idea to open an issue to notify people of things like spelling mistakes instead, or is it more polite to just completely ignore them?

clovergaze commented 3 years ago

Seriously, if you want to improve something, go ahead and do as you please. I like reading stuff without typos in it.

k1nxx commented 3 years ago

message received. Now I know. have a nice day.

sorry to be a pain in the ass. Just tryin to remove bad habits with people fixing typo's in like every repository

No worries. I wouldn't want people spamming my repos either. For future reference, is it a good idea to open an issue to notify people of things like spelling mistakes instead, or is it more polite to just completely ignore them?

i rlly would say you can ignore them. But i dont know why you closed this pull. I didn't tell you to remove it i just told you that it can be quite annoying :)

i'd be happy if you re-opened this

schbz commented 3 years ago

Ok cool thanks.

thedaviddias commented 3 years ago

Ok cool thanks.

I'm sorry @schbz to have not seen this conversation before, any contribution is valuable, thanks for fixing an issue even it's just a typo issue.

@9ebd7134 we have rules on Github and on this repo, respect is one of the rule, please avoid discouraging newcomers just trying to enter in the world of open-source. Anyone can starts with what they feel confortable.