[1.20.1]: Modded advancements in the advancementBlacklist make singleplayer worlds unjoinable due to invalid player data.

[Billnotic]

Versions

• Minecraft Version: 1.20.1
• Forge Version:
• Custom Advancements Version: 7.0.8

Describe the bug I tried using this mod, generated advancements for all the mods and blacklisted the names of one I did not want. This caused all worlds to be unjoinable until I emptied advancementBlacklist again.

Steps to reproduce Steps to reproduce the behavior:

1. Generate advancements for your mods.
2. Add a modded advancement to the blacklist.
3. Restart Minecraft
4. Try to join a singleplayer world, it will not work.

Screenshots and Logs debug.log

Additional context The mod whose advancement I was removing was plenty of golems, although I doubt its specific to them.

[thedead2]

Hi thanks for reaching out! Unfortunately this id a classic example of problems that can occur when removing advancements. Custom Advancements itself works as intended but another mod, in your case probably "notenoughgolems/ Plenty of Golems", tries to access an advancement that was removed and do something with it. As the advancement wasn't loaded as it was removed, the mod cannot access the advancement and an exception is thrown, preventing you from joining the world. I will have a look if there is anything I can do to prevent such errors in future but I'm afraid there isn't. Until then, the only thing you can do, is testing wich advancement causes the exception when it is removed, by adding the advancements to the "advancementBlacklist" one after another and testing if you can join the world. As I said I think it is an advancement of "notenoughgolems/ Plenty of Golems" but I could be wrong. I will come back to you if I find anything I can do.

[Billnotic]

why was this reopened?

[thedead2]

Hi, this is not fixed in production yet. So in order not to forget about it I reopened this issue.