thedead2 / customadvancements

A minecraft mod that gives players creative freedom about advancements
GNU General Public License v3.0
0 stars 1 forks source link

1.20.1: Custom Advancement Progress Resets #13

Open sherpascott opened 4 months ago

sherpascott commented 4 months ago

Versions

Describe the bug A clear and concise description of what the bug is. When rejoining my single player world, advancement progress will completely reset. This only happens like 1 in 30 times. It's rare, but common enough to kind of ruin the purpose of tracking my advancements.

Steps to reproduce Steps to reproduce the behavior:

  1. Play world with custom advancements
  2. Leave world.
  3. Join world back
  4. Advancements reset

Screenshots and Logs Please provide the latest.log file or better the debug.log file. If the game crashed, please provide the crash-report. If applicable, add screenshots to help explain your problem. The log is a .gz file and I can't open it :/ but here it is

2024-04-27-1.log.gz

Additional context Add any other context about the problem here, e.g. additional mods you have installed. I do use sinytra connector for fabric mods, so it may cause issues.

sherpascott commented 4 months ago

I figured out how to open .gz files with Peazip and here's what I found in the log. Idk if this helps or not. I would like to also say that this mod is amazing! And thank you for your work. It's so useful when it's working correctly, I'm just not sure why this bug is happening. It's reset my progress like 4 times over the past two months, but it's rare only like a 5% chance it'll happen when I join the world. image

sherpascott commented 4 months ago

Some of the mods it's referencing, like dolt compat, were removed ages ago from the pack, so I'm not sure why it's showing up.

thedead2 commented 4 months ago

Hi, thanks for reaching out. I'm currently quite busy with University so it might take a while but I will come back to you.

sherpascott commented 4 months ago

No worries I feel that finals week is rough. Good luck

thedead2 commented 4 months ago

Hi, I'm sorry but the log you've provided above seems to be incomplete and doesn't contain any errors related to custom advancements. So if you have another log containing the error please share it with me. If you have previously generated the game advancements and deleted some mods afterwards, the generated advancements remain and will not be deleted and custom advancements will still try to load them. That's probably the reason why they still appear in the log. This is something I'll change with the next update. Regarding your original problem with the progress being reseted once in a while: First of all, please make sure you've disabled the config option to reset the progress when you die. Second, please provide the corresponding log if the error persist. Hope this helps for now.

sherpascott commented 4 months ago

Hey thanks so much for the help. I'll go through and double check the files on my end to see what could be messing things up. I'm looking forward to that change though that will be very nice.

That's weird, I thought that was the log from that particular session where it reset, but I must've got it mixed up. I'm not sure how to replicate the advancement reset to be honest, because it was a fluke thing and only happened a couple times, but it's weird that it happened more than once. I'll keep you posted if I experience it again.

Appreciate all your work!