search

thedead2 / customadvancements

A minecraft mod that gives players creative freedom about advancements
GNU General Public License v3.0
0 stars 1 forks source link

1.20.1: Crash on world creation #14

Open SCsupercraft opened 4 months ago

SCsupercraft commented 4 months ago

Versions

Describe the bug Game crashes on world creation

Steps to reproduce Steps to reproduce the behavior:

  1. Create world
  2. That's it

Screenshots and Logs

crash-2024-05-10_19.08.09-client.txt latest.log Screenshot 2024-05-10 191404

Additional context

Here is the pack it occurred on Create Factory Builder-Alpha 0.5.0.zip

SCsupercraft commented 4 months ago

@thedead2 it also seems to be the reason you get this screen when loading a world (happens every other time)

image

Here is the full log latest.log

thedead2 commented 4 months ago

Hi, thanks for reaching out. I can't tell directly from the log, what is going wrong. My best guess is, that the mod is trying to remove an advancement (by its id) which doesn't exist. Maybe it's a misspelled resource location in the blacklist/ whitelist section of the config. Please check those entries and make sure they are all resource locations of existing advancements. You can try to remove all entries one by one to check wich entry is causing the crash. My other guess is that it has to do with the advancement datapack you've installed. I actually never tested the mod with datapacks so I can't really say if it's compatible or not. So if the above method of removing advancement's one by one from the blacklist/ whitelist doesn't work, try to remove the advancement datapack. Either way, this shouldn't cause the game to crash, so I will try to change the code so your game won't crash if something like this happens and rather will give you an detailed description what went wrong. Hope this helps.

PS: Please don't post code as a comment, it's almost impossible to read that way. Attaching the log is better.

SCsupercraft commented 4 months ago

Yep, you were right I must of removed some of the modpacks advancements for that build since they were not finished but clearly forgot the remove them from the whitelist. Thanks for your help, everything works properly now!

thedead2 commented 4 months ago

Hi that sounds great. Glad I could help. I will keep this issue open until I've released a fix so the game won't crash directly and instead tries to tell you what went wrong instead.