search

thedead2 / customadvancements

A minecraft mod that gives players creative freedom about advancements
GNU General Public License v3.0
0 stars 1 forks source link

The advancement screen is out of wack #9

Closed ImpulsiveLad closed 1 year ago

ImpulsiveLad commented 1 year ago

I am in 1.20.1 forge with the 1.20.1-7.0.8 version of the mod 2023-10-14_12 42 50 as you can see the bottom row of advancement tabs are translated to the right

thedead2 commented 1 year ago

Hi thanks for reaching out, which other mods have you installed? Maybe it's a bug between Custom Advancements and another mod. CA itself only alters the background of the advancement screen and which advancements are loaded. It shouldn't alter anything else.

ImpulsiveLad commented 1 year ago

Well I'm working on a modpack and am using it as a tool for it, Screenshot 2023-10-15 125303

thedead2 commented 1 year ago

If you remove Custom Advancements from your pack, does the advancement screen still looks broken or is it fixed?

ImpulsiveLad commented 1 year ago

2023-10-15_18 58 26 Just removed custom advancements and opened up a world

thedead2 commented 1 year ago

Hmm, ok I will have a look at it and then get back to you.

ImpulsiveLad commented 1 year ago

Could this be perhaps because I removed the sample advancements and that tab? Can’t test it rn, in lecture

I also tested the mod in neoforge 47.1.76 and the issue persisted

thedead2 commented 1 year ago

No that's probably not the reason. The example tab is just that, an example. You could basically have the mod installed and no advancement loaded, wouldn't really make sense but it's possible. I'm quite certain that it's an incompatibility between CA and another mod. Hadn't time testing it though but I will look at it tomorrow. If you want to, you could also try removing one mod after another without removing Custom Advancements and test whether the bug persists.

If I'm not mistaken currently all forge mods are compatible with NeoForge as they share most of their code. But the mod wasn't programmed for NeoForge so if something isn't working in NeoForge there's currently no fix. But I will consider releasing a version for NeoForge if the time has come.

thedead2 commented 1 year ago

Ok I tried to recreate your mod pack it makes no sense with the list you've provided above. There are lots of mods that are for fabric which will definitely not work with forge, also a lot of mods are outdated so make sure to have the newest versions of these mods installed. It would be helpful if you could provide a link to download your mod pack so I don't have to recreate it mod per mod.

ImpulsiveLad commented 1 year ago

oh I don't have the pack anymore, I've been changing it actively

thedead2 commented 1 year ago

Ok does the issue still persist with the new version of the pack? If so, could you please provide a link to the new pack.

ImpulsiveLad commented 1 year ago

I don't currently use the mod since I realized I can remove advancements by going into the jars and deleting the relevant json

thedead2 commented 1 year ago

Please note: If you are altering the jars of mods you have downloaded, this firstly might not be compliant with the license of the mod, secondly you will habe to delete the json files manually with every update of any mod and thirdly you can not really share the modpack via clients like the curseforge client as those always download the mods directly. Anyway, this is off-topic. As you don't use the mod currently and I can't reproduce the bug with the given information I'm closing this issue now. Feel free to reopen it if the bug occurs again.