Fixed plugin to use it with web-component-tester version >= 6.4.0.

[angulito]

• Replaced prepare:webserver hook event by define:webserver and replace waterfall-server by express.
• Refactor to use let and const annotations and function declarations.
• Removed unused dependencies.
• Added method to add not coverage files that match with the options.include pattern and don't match with the options.exclude pattern but this files don't be imported/used by the tests, so the coverage is 0.
• Updated the example in the README.md file, because the exclude pattern don't should start with '/' now.

[212361828]

An update to make this plugin work with 6.4 is sorely needed. Is this repo still being maintained?

[megheaiulian]

@AnguloHerrera The PR works fine for a single test suite file. But when you have something like that -> https://github.com/PolymerElements/iron-selector/blob/master/test/index.html and the same file is loaded again code coverage for it isn't updated. The problem is caching. When the same file is loaded again instrumentAsset and/or instrumentHtml no longer calls instrumentSync.

[angulito]

@megheaiulian, is it fixed with those changes? https://github.com/AnguloHerrera/web-component-tester-istanbul/tree/develop

I have updated to set into cache the url plus query params.

I don't remove the cache because if I do it, then it can have problems with the rest petitions and the middleware, because they are intercepted, so the petition must be set into cache if it is the first time that the file is called.

Feel free to do a PR to my repository to fix it.

Thanks.

[megheaiulian]

@AnguloHerrera Fixed it with this commit https://github.com/plumelo/web-component-tester-istanbul/commit/52093bde2ae673a16f606e2c36cd16f253e516fc. When instrumented content is already in cache it should be returned ? The else case of if(!cache[asset]) ?

[angulito]

Ok, thanks @megheaiulian, now it should be fixed 👍

[angulito]

I have uploaded a new npm package with those changes. I hope this PR is merged and that provisional npm package is not needed anymore. https://www.npmjs.com/package/web-component-tester-istanbulcoverage

[megheaiulian]

@AnguloHerrera Thank you. I too hope it gets merged.

[kongxiangyan]

Awesome job !!! Bring me out of confusions after trying almost every method. Thanks too much !