search

thedevdojo / chatter

Chatter is a Simple Laravel Forum Package
https://devdojo.com/forums
MIT License
898 stars 294 forks source link

set the email subject of notification mails #168

Open gerbenjacobs opened 6 years ago

gerbenjacobs commented 6 years ago

At the moment you can not change the subject of the notification email.

It will fall back on Laravel and tries to create a name based on the class ChatterDiscussionUpdated.php resulting in "Chatter Discussion Updated".

I was thinking about fixing this, but I'm not sure what we want:

  1. A complete free form field in config i.e. chatter.email.subject

  2. A translatable but hardcoded string i.e. "Discussion Updated"

Both solutions have pros and cons for adjustability, translating and default values (or lack thereof).

gerbenjacobs commented 6 years ago

My preference goes towards the translatable option, because the body of the mail is already translatable. But I'd also like to add like my sitename (or APP_NAME) in the subject line..

marktopper commented 6 years ago

We are open to pull requests adding optional parameters to the language string for the email subject.