search

thedevdojo / chatter

Chatter is a Simple Laravel Forum Package
https://devdojo.com/forums
MIT License
900 stars 294 forks source link

[Suggest] use laravel localization #83

Open RibesAlexandre opened 7 years ago

RibesAlexandre commented 7 years ago

Hi,

I think it could be usefull for non english people to use langs resources instead of plain text, In this way, it will no longer be necessary to modify source code to change messages text.

Thanks, Regards.

chrisbbreuer commented 7 years ago

I like it and it shouldn't be too hard to implement. Can you send in a PR? I would use it, but I don't have much usage for it right now myself

Gumlokt commented 7 years ago

Nowadays localization is one of the important features in most web-apps. I'm looking forward to it...

chrisbbreuer commented 7 years ago

0.3 will have that. You can already use it, just use the 0.3 branch

https://github.com/thedevdojo/chatter/commit/aea6037d945b985465e160bddf778fbba69f7bf4

Gumlokt commented 7 years ago

Thanks for the help. i'll try it

ux-engineer commented 7 years ago

@Chinese1904 is there a roadmap somewhere...when will 0.3 be released? Is it yet stable enough to used on a live site?

ux-engineer commented 7 years ago

There is a bug with current 0.3 branch, on scripts-discussion.blade.php line 132:

$('.delete_response').click(function(){
    post_id = $(this).parents('li').data('id');
    $.form('/{{ Config::get('chatter.routes.home') }}/posts/' + post_id, { _token: '{{ csrf_token() }}', _method: 'DELETE'}, 'POST').submit();
});

That 'posts' url segment is hardcoded and not taken from config. Also on line 109.

And on new-response.blade.php line 29.

galdazbiz commented 6 years ago

I just wrote about this language thing.. https://github.com/thedevdojo/chatter/issues/155 I don't understand why was "dismissed" and also I've download that branch, but there're some probems, for example deleting posts give errors. And also, where do I change "en" to "es" because by default is "en". Are there're any chance to have languages in now and be merged into the master so then it can be included in the offical stable version?

mckenziearts commented 6 years ago

Nothing new here? i have laravel localization on my laravel app but it still not working with the package