Tabs Example 1 Missing Active Tab Function - Githubissues

thedevdojo / pines

The Pines UI library

https://devdojo.com/pines

2.13k stars 86 forks source link

Tabs Example 1 Missing Active Tab Function #16

Closed tylersloan closed 11 months ago

tylersloan commented 11 months ago

Add `tabButtonActive` back to tabs example 1. this is needed for dynamic classnames to work.

Before:

Missing function console error
Text color isn't darker

After:

No console error
Text darker

Other Notes:

Think this was just accidentally a few weeks ago (https://github.com/thedevdojo/pines/commit/5c42b388cacf137a6d7a8b51b1fe44dcb8ab8dba#diff-68b08c735e1fdc2e5e02c8499cca0459d3199cee2e1f5645ed2a1da865bd9d86) 🤷‍♂️
The active class list includes a class to make the tab background darker but the tabMarker itself has the darker background so there's some duplication a bit, but leaving as it isn't related to actual functionality

tnylea commented 11 months ago

Awesome! Thanks man 🕺