thedevdojo / voyager

Voyager - The Missing Laravel Admin
https://voyager.devdojo.com
MIT License
11.78k stars 2.67k forks source link

Upgrade guide missing browse_compass permission seeding #2177

Closed ux-engineer closed 6 years ago

ux-engineer commented 6 years ago

I started using Voyager on this project from version 0.11.10 and recently upgraded to 1.0.7.

Now I've noticed that _browsecompass permission is missing from permissions table and the upgrade guide has no mention on changes to default seeded dataset. Is there something missing also?

ux-engineer commented 6 years ago

Here: https://github.com/the-control-group/voyager/compare/v0.11.10...master

Choose Files changed (892). Use browser's search for 'seeder'. There are 14 matches for modified seeder files.

ux-engineer commented 6 years ago

Also noticed config/voyager.php has these new additions also missing from the upgrade guide:

/*
|--------------------------------------------------------------------------
| Automatic Procedures
|--------------------------------------------------------------------------
|
| When a change happens on Voyager, we can automate some routines.
|
*/
// When a BREAD is added, create the Menu item using the BREAD properties.
'add_bread_menu_item' => true,
// When a BREAD is added, create the related Permission.
'add_bread_permission' => true,

'googlemaps' => [
    'key'    => env('GOOGLE_MAPS_KEY', ''),
    'center' => [
        'lat' => env('GOOGLE_MAPS_DEFAULT_CENTER_LAT', '32.715738'),
        'lng' => env('GOOGLE_MAPS_DEFAULT_CENTER_LNG', '-117.161084'),
    ],
    'zoom' => env('GOOGLE_MAPS_DEFAULT_ZOOM', 11),
],
fletch3555 commented 6 years ago

The upgrade guide is not written with the intention of walking you through every new line you need to write to your config files. I personally think it should be common sense that published config files may have new entries you'll need to get, but I also completely understand the argument that those entries aren't documented anywhere.

Our docs allow submission of suggested changes. You're welcome to type up any necessary changes you find and submit them there. We'll be glad to review them there.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.