thedevdojo / voyager

Voyager - The Missing Laravel Admin
https://voyager.devdojo.com
MIT License
11.8k stars 2.67k forks source link

Adding timestamps and soft deletes from table builder causes error #3364

Open ZeroThe2nd opened 6 years ago

ZeroThe2nd commented 6 years ago

Version information

Description

When creating a new table from within the Voyager control panel, then using the "+ Add timestamps" and "+ Add soft deletes" buttons results in an error that "timestamp" is not a valid datatype. The "timestamp" type is also not selectable in the drop-down menu, and other tables use a "datetime" field instead.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Menu > Tools > Database > Create new'
  2. Click on either the "+ Add timestamps" or "+ Add soft delete"
  3. Error message should appear in the top-right. The data types default to "time" instead.

Expected behavior

Since SQLite3 does not internally support timestamps, auto-select another default value that does work, for example "datetime" as the other generated tables are set to.

Additional context

This application is only using an SQLite3 database in the development environment.

fletch3555 commented 6 years ago

PRs welcomed