search

thedevdojo / voyager

Voyager - The Missing Laravel Admin
https://voyager.devdojo.com
MIT License
11.77k stars 2.67k forks source link

[BUG] Failed update #4011

Closed tommiekn closed 5 years ago

tommiekn commented 5 years ago

Version information

Description

I have recently updated to the latest version from 1.1.10, i use voyager on two different laravel installation, and in only one of these i am having multiple issues i hope you could help to figure out.

List of changes from composer update is mostly minor versions, i keep always everything updated:

  - Removing doctrine/reflection (v1.0.0)
  - Removing doctrine/persistence (v1.1.0)
  - Removing doctrine/common (v2.10.0)
  - Removing doctrine/collections (v1.5.0)
  - Removing doctrine/annotations (v1.6.0)
  - Updating vlucas/phpdotenv (v2.5.1 => v2.6.1): Downloading (100%)         
  - Updating symfony/css-selector (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/var-dumper (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/routing (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/process (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/http-foundation (v4.2.1 => v4.2.4): Downloading (100%)         
  - Installing symfony/polyfill-intl-idn (v1.10.0): Downloading (100%)         
  - Updating symfony/event-dispatcher (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/debug (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/http-kernel (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/finder (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating symfony/console (v4.2.1 => v4.2.4): Downloading (100%)         
  - Installing symfony/polyfill-iconv (v1.10.0): Downloading (100%)         
  - Updating swiftmailer/swiftmailer (v6.1.3 => v6.2.0): Downloading (100%)         
  - Updating symfony/translation (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating league/flysystem (1.0.49 => 1.0.50): Downloading (100%)         
  - Updating anhskohbo/no-captcha (3.0.3 => 3.0.4): Downloading (100%)         
  - Updating barryvdh/laravel-cors (v0.11.2 => v0.11.3): Downloading (100%)         
  - Updating fideloper/proxy (4.0.0 => 4.1.0): Downloading (100%)         
  - Updating symfony/filesystem (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating justinrainbow/json-schema (5.2.7 => 5.2.8): Downloading (100%)         
  - Updating composer/xdebug-handler (1.3.1 => 1.3.2): Downloading (100%)         
  - Updating composer/ca-bundle (1.1.3 => 1.1.4): Downloading (100%)         
  - Updating composer/composer (1.8.0 => 1.8.4): Downloading (100%)         
  - Updating doctrine/dbal (v2.7.2 => v2.9.2): Downloading (100%)         
  - Updating larapack/doctrine-support (v0.1.7 => v0.1.8): Downloading (100%)         
  - Updating larapack/voyager-hooks (v1.0.8 => v1.2.1): Downloading (100%)         
  - Updating tcg/voyager (v1.1.10 => v1.2.2): Downloading (100%)         
  - Updating pvtl/voyager-pages (0.2.7 => 0.2.9): Downloading (100%)         
  - Updating tightenco/collect (v5.7.18 => v5.8.4): Downloading (100%)         
  - Updating symfony/dom-crawler (v4.2.1 => v4.2.4): Downloading (100%)         
  - Updating spatie/robots-txt (1.0.1 => 1.0.3): Downloading (100%)         
  - Updating spatie/image-optimizer (1.1.3 => 1.1.5): Downloading (100%)         
  - Updating spatie/image (1.5.2 => 1.6.0): Downloading (100%)         
  - Updating spatie/browsershot (3.26.0 => 3.27.0): Downloading (100%)         
  - Updating spatie/crawler (4.2.0 => 4.3.0): Downloading (100%)         
  - Updating spatie/laravel-sitemap (5.2.7 => 5.2.11): Downloading (100%)         
  - Updating pvtl/voyager-blog (0.2.4 => 0.2.7): Downloading (100%)         
  - Updating pvtl/voyager-page-blocks (0.8.5 => 0.8.7): Downloading (100%)         
  - Updating tymon/jwt-auth (1.0.0-rc.3 => 1.0.0-rc.4.1): Downloading (100%)         
  - Updating mockery/mockery (1.2.0 => 1.2.2): Downloading (100%)         
  - Updating sebastian/environment (4.0.1 => 4.1.0): Downloading (100%)         
  - Updating sebastian/diff (3.0.1 => 3.0.2): Downloading (100%)         
  - Updating phpunit/php-timer (2.0.0 => 2.1.1): Downloading (100%)         
  - Updating phpunit/phpunit (7.5.1 => 7.5.6): Downloading (100%)         
  - Updating nikic/php-parser (v4.1.0 => v4.2.1): Downloading (100%)

I deleted cache, preferences, routes, views.

Problem is:

These the logs i get from this latest error:

(1/1) ReflectionException
Class ActionsController does not exist
in Container.php line 767
--
at ReflectionClass->__construct('ActionsController')in Container.php line 767
at Container->build('ActionsController')in Container.php line 646

If i remove the controller value from bread, it works. I have tried with empty controllers so isnt a matter of the content of the controller itself, but seems somehow cant call the class.

Thanks

emptynick commented 5 years ago

Can you post the whole stacktrace, preferably as a screenshot?

tommiekn commented 5 years ago

Hi @emptynick , seems i solved the issue.

Not sure what changed your side, but the issue were that before i used to have "Voyager/controllername" on Controller Name in Bread.

Now to work i need to specify the whole path, App\Http\Controllers\Voyager\controllername

emptynick commented 5 years ago

The only thing I can think if is that custom controller namespaces were made absolute instead of relative to TCG\Voyager (which doesn't make sense at all)

tommiekn commented 5 years ago

@emptynick What should be input there following the proper way? Just the controller name?

Before this update i assumed the path was generated as App\Http\Controllers\WHATEVERYOUWRITEONBREAD

emptynick commented 5 years ago

Its never been like that. App is only the default name generated by Laravel and could be renamed to whatever you like and Voyager doesn't know that. Just insert the full namespace + class-name

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.