[Feature] Google Analytics config - use access code instead of Oauth client id

minhdanh commented 5 years ago

Version information

Laravel: v5.8
Voyager: v1.2.3
PHP: 7.2
Database: MySQL 5.7

Description of problem

At the moment Google Analytics integration is being done using an Oauth2 client key, which has the following disadvantages:

Every user has to authorize with their google account separately. The authorization is not shared. This is difficult for normal admin users that have no idea what is a Google Analytics account. Moreover, the integration has to be configured multiple times for multiple users.
Because the authorization is not shared, different accounts can have access to different property. There's no way to stick the admin dashboard to a Google Analytics property. This can be misleading for unskilled users.
To see the data of the same site, different laravel accounts need to share the same google account to authorize, or the Google analytics property must be pre-shared between accounts.

Proposed solution

I looked at the Google Analytics wordpress plugin and what it is doing is to use an access code (see: https://exactmetrics.com/quick-start-guide/): an admin will configure the access code once, and locked to a property. Any other users log in later can see Google Analytics data without having configure Google Analytics for themselves again. The data is consistent between users.

I'm willing to create a PR for this, but please let me know if that makes sense. Thanks.

minhdanh commented 5 years ago

@emptynick @fletch3555 What do you think about this?

fletch3555 commented 5 years ago

I'm not necessarily opposed to the change, but I'm not sure I understand your reasoning for it. Can you explain what you mean by "each user"?

minhdanh commented 5 years ago

Maybe you're unsure about this? Every user has to authorize with their google account separately. By every user I mean the Voyager admin users. Each of them has to configure Google Analytics on their own to have the GA graphs show up in Voyager dashboard. Using the proposed solution an admin only needs to configure Google Analytics integration once and then other admin can see the GA graphs.

irakliShengelia commented 3 years ago

Stuck with this issue myself. I think that should really be the main way to configure it. What's the point of adding it to the website dashboard if you still need to log in via google.

thedevdojo / voyager