Settings cache works incorrect when more than one dot in key

[nixprosoft]

Version information

• Laravel: v6.6.2
• Voyager: v1.3.0
• PHP: 7.2.22
• Database: MySQL 5.7

Description

A clear and concise description of what the bug is.

Steps To Reproduce

Steps to reproduce the behavior:

1. If settings key have more than one dot like this: You will get this in <?php dump(settings('site')); ?> And you cannot access <?php dump(settings('site.yandex.metrika')); ?> for example.

Expected behavior

<?php dump(settings('site.yandex.metrika')); ?> must return value of site.yandex.metrika key.

[MrCrayon]

There should be a check that doesn't let you use dots in key names.

Using dots is a problem because when you send: <input name="site.contacts.phone"> this gets automatically changed from Laravel => Symfony => PHP to: site_contacts_phone since dots are not allowed in variable names.

This would lead to unespected behaviour if you have both site.contacts.phone and site.contacts_phone.

Solution Use underscore notation for key names.

P.S. You can dd($request->all()) after sending something with a dot in name and see the result.