search

thedevdojo / voyager

Voyager - The Missing Laravel Admin
https://voyager.devdojo.com
MIT License
11.78k stars 2.67k forks source link

cann't install on laravel 6.18.40 #5097

Closed yannnaingoo closed 3 years ago

yannnaingoo commented 4 years ago

Version information

Description

Problem 1

MrCrayon commented 4 years ago

We cannot know what's the problem. ~Something is preventing~ Voyager v1.4.2 ~to be installed and v1.4.0~ had a fixed reference for league/flysystem.

If I were you I'd update PHP and try again since it will be EOL in two months anyway.

Edit Problem is fixed in v1.4.x-dev and v1.4.3 when released

fletch3555 commented 4 years ago

The issue is that you have a specific version of league/flysystem required (either in your composer.json or from another package), but Voyager needs a different version. This causes contention. If you don't have that package locked at a specific version (i.e. 1.1.3, not ^1.1 or 1.1.*) in your composer.json, then delete your composer.lock file and try again.

yannnaingoo commented 4 years ago

We cannot know what's the problem. Something is preventing Voyager v1.4.2 to be installed and v1.4.0 had a fixed reference for league/flysystem.

If I were you I'd update PHP and try again since it will be EOL in two months anyway.

I updated php version 7.2 to 7.3 but cann't install voyager

yannnaingoo commented 4 years ago

The issue is that you have a specific version of league/flysystem required (either in your composer.json or from another package), but Voyager needs a different version. This causes contention. If you don't have that package locked at a specific version (i.e. 1.1.3, not ^1.1 or 1.1.*) in your composer.json, then delete your composer.lock file and try again.

I tried like that but issue is same before

yannnaingoo commented 4 years ago

I have been try to install by upgrade laravel 7 but cann't install.

SamuelWei commented 3 years ago

I can confirm this issue for laravel versions newer then 6.18.40. To me it looks like the latest stable version of voyager requires league/flysystem: ~1.0.41 (https://packagist.org/packages/tcg/voyager#v1.4.2) but the laravel 6 framework league/flysystem: ^1.1 (https://packagist.org/packages/laravel/framework#v6.20.16)

MrCrayon commented 3 years ago

@SamuelWei that's accurate, I thought it was fixed in 1.4.2 but it's only fixed in dev with merged https://github.com/the-control-group/voyager/pull/5068. @yannnaingoo untill 1.4.3 is released you'll need to require 1.4.x-dev setting minimum-stabilitydev in composer.json

SamuelWei commented 3 years ago

@SamuelWei that's accurate, I thought it was fixed in 1.4.2 but it's only fixed in dev with merged #5068. @yannnaingoo untill 1.4.3 is released you'll need to require 1.4.x-dev setting minimum-stabilitydev in composer.json

My problem is, that I need to update laravel due to a security issue (https://github.com/advisories/GHSA-3p32-j457-pg5x and https://github.com/advisories/GHSA-x7p5-p2c9-phvg) but don't want to install an unstable version of voyager for production usage. Would it be possible to release 1.4.3 with newer dependencies (+ bugfixes) and have the new features in a 1.4.4 release?

MrCrayon commented 3 years ago

@SamuelWei we don't have much man power to manage that but you can fork Voyager and apply #5068 or any other fix you want, so you have total control of what to update.

I'm closing this since fix is already merged.

SamuelWei commented 3 years ago

@MrCrayon Can't you just release a new Version with the fix, since your last Release is Jun 2020.

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. If you have further questions please ask in our Slack group.