Open laravel-shift opened 1 year ago
:warning: Shift detected a dependency for the laravel/framework
. Unless you have a special requirement for depending on the entire Laravel framework, it's recommended to add dependencies for the specific illuminate
packages instead.
:warning: Shift detected GitHub Actions which run jobs using a version matrix
. Shift attempted to update your configuration for Laravel 10. However, you should review these changes to ensure the desired combination of versions are built for your package.
:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories
property of your composer.json
:
{
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/voyager.git"
}
]
}
Then update your dependency constraint to reference this branch:
{
"require": {
"tcg/voyager": "dev-l10-compatibility",
}
}
Finally, run: composer update
This was not enough for me, I encountered bugs when going to Databases and BREAD Error message : Call to undefined method Doctrine\DBAL\Connection::createSchemaManager()
To solve the bug, I removed what concerns Larapack from /vendor/tcg/voyager/src/VoyagerServiceProvider.php (line 19 and 62)
To solve the bug, I removed what concerns Larapack from /vendor/tcg/voyager/src/VoyagerServiceProvider.php (line 19 and 62)
Tried and didn't work :(
To note, PHP 8.1+ deprecation warnings are being logged by users (#5603, #5737) which might want to be addressed first before pursuing Laravel 10 support.
Also, as Laravel 10 (and Laravel 9) support PHP 8.2, test coverage should be extended to include 8.2.
There are a couple more problems we hit, mostly around orchestra/testbench
.
Please check the 1.6-l10 branch
I've created a PR (#5753) that should make it work with Laravel 10. @u01jmg3 's comment about the deprecation warnings have also been included in it. Hope it can be merged !
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 10.x.
Before merging, you need to:
l10-compatibility
branchIf you do find an issue, please report it by commenting on this PR to help improve future automation.