search

thedevsaddam / gojsonq

A simple Go package to Query over JSON/YAML/XML/CSV Data
https://github.com/thedevsaddam/gojsonq/wiki
MIT License
2.18k stars 140 forks source link

[Add] Proposal for a Out that can be used to paginate the result #43

Closed alejoloaiza closed 5 years ago

alejoloaiza commented 5 years ago

Hi Saddam, please consider this proposal, let me know your comments. Thanks. https://github.com/thedevsaddam/gojsonq/issues/42

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 279

Changes Missing Coverage Covered Lines Changed/Added Lines %
jsonq.go 0 20 0.0%
<!-- Total: 0 20 0.0% -->
Totals Coverage Status
Change from base Build 277: -2.1%
Covered Lines: 932
Relevant Lines: 952
💛 - Coveralls
coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 279

Changes Missing Coverage Covered Lines Changed/Added Lines %
jsonq.go 0 20 0.0%
<!-- Total: 0 20 0.0% -->
Totals Coverage Status
Change from base Build 277: -2.1%
Covered Lines: 932
Relevant Lines: 952
💛 - Coveralls
thedevsaddam commented 5 years ago

@alejoloaiza It would be better to set Offset method, the result will be reflected on the outputs.

Please send PR against dev branch and cover the code tests.

alejoloaiza commented 5 years ago

sure, just gimme a couple of days to do the adjustments i'm having tons of work, cheers.

thedevsaddam commented 5 years ago

Hey I've already added the feature in dev branch, you may help me to ensure the feature is okay.

thedevsaddam commented 5 years ago

As this feature added in v2.2.0, I'm closing the PR.

Thank you very much for the effort (Y)