Closed cifren closed 4 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
result.go | 1 | 2 | 50.0% | ||
<!-- | Total: | 1 | 2 | 50.0% | --> |
Totals | |
---|---|
Change from base Build 341: | -0.08% |
Covered Lines: | 10440 |
Relevant Lines: | 10488 |
I am not sure if I understand that coverage message... can you explain ?
Hi @cifren
Sorry for the late response. You should add test case that tests the code branch you added.
In your particular case is to add test case where methodMap[method]
is empty, e.g. ==""
.
@cifren You must create an issue and discuss it with others about the problem before sending PR.
I think we can add an error and stop panicking
https://github.com/thedevsaddam/gojsonq/blob/master/CONTRIBUTING.md
You are right panicking was a little too much, an error is better.
Thank you for your help.
issue
When using :
This error is displayed an error from reflect library:
Expected
Should display a more specific error that give us more clues in order to understand what is going on