search

thedivtagguy / whoismyneta

Dashboard to explore self-reported details and parliamentary activity of MPs in the 17th Lok Sabha
https://whoismyneta.com/
45 stars 9 forks source link

Modified the conditional rendering logic to ensure that state names are displayed when either hovered over or selected #14

Closed MeAshikeqbal closed 5 months ago

MeAshikeqbal commented 6 months ago

Remove console.log in AssetsHistogram.svelte Modified the conditional rendering logic to ensure that state names are displayed when either hovered over or selected

netlify[bot] commented 6 months ago

Deploy Preview for electionsdatajam ready!

Name Link
Latest commit 295d322bc975576c848abc0cde9a3668faa1bc7f
Latest deploy log https://app.netlify.com/sites/electionsdatajam/deploys/662d88023341e200088aadc0
Deploy Preview https://deploy-preview-14--electionsdatajam.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thedivtagguy commented 6 months ago

Hey, thanks so much for taking the time to contribute! This is a much needed fix.

I have a suggestion since you're at this. For hover text, the font-size should be larger so that it is visible at the zoomed out scale. I avoided doing this because of a time crunch so the small font-size 'corrects' itself to normal when the user is zoomed in.

So maybe, the hover text could have a different font-size depending on the scale value (ICIRC). Let me know if you want to give it a shot.

MeAshikeqbal commented 6 months ago

Hey, Thank you. I will try work on it