search

thedjpetersen / subway

ABANDONED - A web based IRC client
1.47k stars 152 forks source link

Crash moments after joining a channel #328

Closed cjb closed 10 years ago

cjb commented 10 years ago

On refactor branch:

   debug - cleared heartbeat timeout for client GG23TLlkk6bCuOHTfqbg
   debug - set heartbeat interval for client GG23TLlkk6bCuOHTfqbg
{ prefix: 'thedjpetersen!~root@162.243.148.7',
  nick: 'thedjpetersen',
  user: '~root',
  host: '162.243.148.7',
  command: 'PRIVMSG',
  rawCommand: 'PRIVMSG',
  commandType: 'normal',
  args: [ '#subway', 'working on getting /list to work correctly' ],
  client_server: 'irc.freenode.net' }

/home/ubuntu/subway/node_modules/irc/lib/irc.js:664
                    throw err;
                          ^
TypeError: Cannot call method 'get' of undefined
    at app.models.Connection.Backbone.Model.extend.addMessage (/home/ubuntu/subway/src/js/models/models.js:85:59)
    at util.handle_irc (/home/ubuntu/subway/src/js/handle_irc.js:62:16)
    at Client.<anonymous> (/home/ubuntu/subway/lib/connection.js:69:7)
    at Client.EventEmitter.emit (events.js:117:20)
    at /home/ubuntu/subway/node_modules/irc/lib/irc.js:661:22
    at Array.forEach (native)
    at CleartextStream.<anonymous> (/home/ubuntu/subway/node_modules/irc/lib/irc.js:655:15)
    at CleartextStream.EventEmitter.emit (events.js:95:17)
    at CleartextStream.<anonymous> (_stream_readable.js:746:14)
    at CleartextStream.EventEmitter.emit (events.js:92:17)
cjb commented 10 years ago

Hi, I saw this again. I'd just identified with nickserv, and I clicked the close button on the nickserv privmsg window (which didn't make it disappear?) and then the same crash as above for a different channel.

cjb commented 10 years ago

And again, another time. I don't think I was interacting with Subway when it happened this time, was just in response to a new channel message coming in.

cjb commented 10 years ago

I guess the good news is that this happens within five mins of me launching Subway, so we aren't going to have problems getting it to reproduce here. :)

thedjpetersen commented 10 years ago

Should be fixed now

cjb commented 10 years ago

Confirmed fixed.

cjb commented 10 years ago

Just saw this again :( Pretty sure it's related to closing a server status window.

/home/ubuntu/subway/node_modules/irc/lib/irc.js:664
                    throw err;
                          ^
TypeError: Cannot call method 'get' of undefined
    at app.models.Connection.Backbone.Model.extend.addMessage (/home/ubuntu/subway/src/js/models/models.js:98:59)
    at util.handle_irc (/home/ubuntu/subway/src/js/handle_irc.js:62:16)
    at Client.<anonymous> (/home/ubuntu/subway/lib/connection.js:69:7)
    at Client.EventEmitter.emit (events.js:117:20)
    at /home/ubuntu/subway/node_modules/irc/lib/irc.js:661:22
    at Array.forEach (native)
    at Socket.<anonymous> (/home/ubuntu/subway/node_modules/irc/lib/irc.js:655:15)
    at Socket.EventEmitter.emit (events.js:95:17)
    at Socket.<anonymous> (_stream_readable.js:746:14)
    at Socket.EventEmitter.emit (events.js:92:17)
cjb commented 10 years ago

I see it's at a different line of code this time (src/js/models/models.js:98) and that line still uses app.irc.getActiveChannel().