search

thedjpetersen / subway

ABANDONED - A web based IRC client
1.47k stars 152 forks source link

Unable to join channel named "#" #350

Closed gyng closed 10 years ago

gyng commented 10 years ago

/join # and using the sidebar field both do not work on latest 11a7ce03b485f302a17f514ac744bf7cf4f5d8b8 (2014/07/10) master.

My understanding is that according to RFC1459/RFC2812 this should be a valid channel name.

RFC2812 states:

Channels names are strings (beginning with a '&', '#', '+' or '!' character) of length up to fifty (50) characters. Apart from the requirement that the first character is either '&', '#', '+' or '!', the only restriction on a channel name is that it SHALL NOT contain any spaces (' '), a control G (^G or ASCII 7), a comma (',').

nibalizer commented 10 years ago

Bump

thedjpetersen commented 10 years ago

So locally I am able to join a channel named '#' using the tip of master

thedjpetersen commented 10 years ago

Could you retest please?

gyng commented 10 years ago

This issue seems to be resolved now.