Autocompletion fixes and jQuery-less refactor.

thedjpetersen / subway

ABANDONED - A web based IRC client

1.47k stars 152 forks source link

Autocompletion fixes and jQuery-less refactor. #358

Closed Palid closed 10 years ago

Palid commented 10 years ago

Fixed autcompletion and removed needless jQuery.

thedjpetersen commented 10 years ago

A little tough to read the diff - what is this changing besides removing jQuery?

Palid commented 10 years ago

Moved the logic from onKeyUp to onKeyDown - we can prevent the event so browser won't change the focus and modify input's value as supposed. On keyup it wasn't really working as intended.

thedjpetersen commented 10 years ago

OK great! Just one little stylistic thing and this should be good to merge. Thanks!

Palid commented 10 years ago

@thedjpetersen I've ammended the commit with your proposed fixes. Ready to merge!

thedjpetersen commented 10 years ago

Thanks!