search

thedmd / pianobar-windows

Port of pianobar - console based pandora.com player
Other
110 stars 12 forks source link

Support for event_command #40

Open nlowe opened 7 months ago

nlowe commented 7 months ago

On Linux and macOS I use event_command to scrobble to Last.FM. However, on the windows fork, the implementation is commented out:

https://github.com/thedmd/pianobar-windows/blob/191128aa504548a05a886a4b0a32e6f9bc8e299d/src/ui.c#L721-L828

thedmd commented 7 months ago

@nlowe

When porting indeed commented out that part due to use of fork() and at a time not clear understanding how I could implement that.

I will look into that next time I get back to pianobar.

jonmchan commented 6 months ago

+1 for this feature. I was looking into combining this with https://github.com/stuartleeks/wsl-notify-send such that you can have a notification of what the next song in the notification center.

jonmchan commented 3 weeks ago

I'm taking a stab at this. fork() doesn't exist for windows, I think the CreateProcess call is what we will want to use. If I get anything working, I'll submit a PR.

jonmchan commented 3 weeks ago

I implemented this functionality using the CreateProcess as I described above.

Until it get merged into the main branch, you can utilize this function from my forked release: https://github.com/jonmchan/pianobar-windows/releases

@nlowe If you still need this, I would appreciate if you can test this out and let me know if it works for more than just me. Thanks.