thedmd / pixeltoaster

PixelToaster is a framebuffer library for C++
45 stars 9 forks source link

PixelToaster doesn't react correctly to WM_CLOSE on windows. #74

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
* What steps will reproduce the problem?
1. Compile PixelToaster for windows
2. Run ExampleImage
3. Close the window

* What is the expected output? What do you see instead?
- The program should close, but the program continue to loop because 
"display.open()" keeps returning true. This is because of 
incorrect code in the WM_CLOSE handler in PixelToasterWindows.h

* What version of the product are you using? On what operating system?
- PixelToaster-1.4

* Please provide any additional information below.

The WM_CLOSE handling code looks like this:

| case WM_CLOSE:
|   if ( _listener )
|       if ( _listener->onClose( display->wrapper() ? *display->wrapper() : 
*display ) )
|           adapter->exit();
|   else
|       adapter->exit();

but it should be:

| case WM_CLOSE:
|   if ( _listener )
+   {
|       if ( _listener->onClose( display->wrapper() ? *display->wrapper() : 
*display ) )
|           adapter->exit();
+   }
|   else
|       adapter->exit();

Original issue reported on code.google.com by anton.ra...@gmail.com on 16 Nov 2008 at 4:06

GoogleCodeExporter commented 8 years ago
this has already been fixed in the svn version, so the ZIP files must be out of 
date - please verify that if you get 
latest from SVN it works for you, thanks!

Original comment by glenn.fi...@gmail.com on 16 Nov 2008 at 6:44

GoogleCodeExporter commented 8 years ago
i have created a new point release, and uploaded it to google code

you can download it from pixeltoaster.com

cheers

Original comment by glenn.fi...@gmail.com on 16 Nov 2008 at 7:13