thedmd / pixeltoaster

PixelToaster is a framebuffer library for C++
45 stars 9 forks source link

Random crashes on OS X due to uninitialized pointer #80

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Create a Display on OS X

What is the expected output? What do you see instead?
Display opens successfully most of the time; crashes other times.

What version of the product are you using? On what operating system?
Latest SVN on OS X.

Please provide any additional information below.
AppleDisplay's listener pointer is not initialized in its ctor. See fix:

Index: PixelToasterApple.mm
===================================================================
--- PixelToasterApple.mm    (revision 145)
+++ PixelToasterApple.mm    (working copy)
@@ -1220,6 +1220,7 @@
            AppleDisplayPrivate( AppleDisplay* theDisplay )
                    : window(0), view(0),
                        oldWindowFrame(NSZeroRect),
+                       listener(nil),
                        display( theDisplay )
            {
            }

Original issue reported on code.google.com by xo%geeks...@gtempaccount.com on 29 Jul 2010 at 7:26

Attachments:

GoogleCodeExporter commented 8 years ago
Actually, the issue is that the display opens and then crashes whenever an 
event is fired (e.g. mouse moved).

Original comment by xo%geeks...@gtempaccount.com on 29 Jul 2010 at 7:27

GoogleCodeExporter commented 8 years ago
Thanks for finding this and supplying a patch.
Fixed with svn rev. #146.

Original comment by tscha...@gmail.com on 8 Aug 2010 at 8:44