search

thednp / bootstrap.native

Bootstrap components build with Typescript
http://thednp.github.io/bootstrap.native/
MIT License
1.7k stars 178 forks source link

Navbar with off-canvas drawer is hidden by backdrop #458

Closed trucksmart closed 1 year ago

trucksmart commented 1 year ago

If you have a navbar with an off-canvas drawer, the backdrop hides it. The official Bootstrap backdrop is appended to the navbar while Bootstrap.Native backdrop is appended to the document body.

thednp commented 1 year ago

Can you have a codepen link or something to see the diffrence?

trucksmart commented 1 year ago

Bootstrap Official Bootstrap Native

trucksmart commented 1 year ago

The backdrop utility has the document body hardcoded in. Adding an option for a mounting point then defaulting to the document body if none is provided seems like an excellent addition.

thednp commented 1 year ago

What if you move the offcanvas outside of the navbar, it should work as expected. In other cases a fixed/static navbar to also hold an offcanvas which is also fixed bad.

I've developed the utility to drop the browser notification for slow render, but also with less hustle. The point I'm trying to make is that less configuration for more functionality is best, sounds good?

trucksmart commented 1 year ago

That's perfectly reasonable. Thanks!