search

thednp / solid-color-picker

🎨 Modern Color Picker for SolidJS
https://thednp.github.io/solid-color-picker/
MIT License
10 stars 1 forks source link

The after number input fields turn to 1 the flip to 255 and alpha channel one doesn't work at all, #2

Closed Dakotys closed 1 month ago

Dakotys commented 2 months ago

Describe the bug

image then decrease to one and it jumps to 255 image

then alpha channels inputs step buttons dont work at all, typing directly into alpha channel updates the color but doesnt update the slider image then i typed 1 and it flipped back to 63 but the color changed but slider stayed the same image

when setting directly the rgb the color changes but the hue slider and main value square doesnt update

Minimal Reproduction Link

https://thednp.github.io/solid-color-picker/

thednp commented 2 months ago

Thanks for reporting, will look into it asap.

thednp commented 2 months ago

@Dakotys thanks for bringing this to my attention.

At launch all these color-picker versions were working flawless. It would seem there have been some browser changes that break the functionality.

Rest assured I'll try to fix it asap.

thednp commented 2 months ago

@Dakotys it all has to do with bound01. I'm reworking all of it to be consistent at all times. Will let you know when done and ready to test :smile:

thednp commented 1 month ago

@Dakotys please test the vanilla version https://thednp.github.io/color-picker/

I just finished updating it with Vitest (I can actually test stuff now on my PC).

The same treatment will be applied here.

thednp commented 1 month ago

@Dakotys please test v0.0.10.

Feel free to close the issue and thank you again for reporting.

Dakotys commented 1 month ago

@Dakotys please test v0.0.10.

Feel free to close the issue and thank you again for reporting.

Seems good just alpha input box resets to 100 when stepping down. And on mobile devices when someone opens color picker dropdown it should blur all focus otherwise it keeps reopening keyboard for input typing that obscures the color picker.

thednp commented 1 month ago

Yea.. forgot to update the alpha handling, easy fix there, I'm updating some testing and event handlers and will push an update as soon as it's ready.

thednp commented 1 month ago

Alright, I've reworked and fixed most issues in v0.0.11. Spoiler: there's still work to be done.

Please check :smile:

thednp commented 1 month ago

v0.0.12