Closed acodili-jg closed 4 months ago
I think a lot of what's going on here has some merit, however there are a few things that need modification here:
MemoiseGetAllDependenciesAnyways
are far too verbose, and are a bit hard to grasp what's going on with.Before bothering with these changes, let me give an implementation a try. I'll post updates here.
I agree with the points mentioned and it's good to know yours and hopefully others' perspectives. Regarding the deprecation, mostly on Utils.memoize
, I was using it to get a warning on usage of it, though thinking back I could have used TODO comments.
Ended up going with my implementation (as discussed on discord). See a182489 for details.
What changed?
fivefour runtime exception classes to represent a type of memoization exceptionWhat didn't change (yet)?
I might have missed something, but hopefully this is all the main points.