Update Material.java - Githubissues

thedocruby / resounding

A New Minecraft mod that provides realistic audio physics using parallel wave tracing and an improved physics algorithm.

https://thedocruby.dev/resounding

GNU Lesser General Public License v3.0

85 stars 4 forks source link

Update Material.java #113

Closed acodili-jg closed 2 months ago

acodili-jg commented 2 months ago

Replaced @NotNull Double with a primitive double
Input validation for component state to be between zero and one
Documentation

mikenrafter commented 2 months ago

Why redefine getters when records do this automatically for you? It makes clear sense on the state property, but not elsewhere.

acodili-jg commented 2 months ago

I did redefine them, which is unnecessary and I had no other valid reason other than "Change the letter casing for the description". ~~Should I remove them?~~ Edit: I should remove them now.