thedocruby / resounding

A New Minecraft mod that provides realistic audio physics using parallel wave tracing and an improved physics algorithm.
https://thedocruby.dev/resounding
GNU Lesser General Public License v3.0
85 stars 4 forks source link

[AmbientSounds] muting #62

Open DrSNAFU opened 2 years ago

DrSNAFU commented 2 years ago

Describe the bug The AmbientSounds mod doesn't function alongside Resounding. Only one or the other will work. If I use Modmenu to turn off Resounding, Ambientsounds will immediately work again. Turning Resounding back on does nothing. AmbientSounds continue to function, Resounding does not. Restarting the game is required to change this.

To Reproduce Steps to observe the issue:

  1. Open game and stand in a biome, listening for ambient sfx.
  2. Go underground to verify Resounding functions.
  3. Use ModMenu to toggle Resounding to off.
  4. Stand above ground to listen for ambient sfx again.
  5. Go back into ModMenu and turn Resounding back on.
  6. Go back underground to see if Resounding still functions.

Expected behavior The mods would presumably work together.

My Machine (please complete the following information):

Additional context I also conducted this test without ModMenu installed, though I wasn't able to turn off Resounding in that case, I determined ModMenu didn't cause the issue.

Crash Report/Logs No crash or error logs were generated, which was odd.

Tinh1000000 commented 2 years ago

After a little of options fiddling I believe the sound absorption by humidity option is the cause of this issue.

For whatever reason, Ambient Sounds get filtered through the humidity absorption filter and thus they get filtered to the point of not hearing them at all.

The only known workaround at the moment is to set that sound absorption by humidity option to 0 in the config of Resounding. I personally won't find this workaround a major issue as the difference is fairly negligible anyway in my playthrough.

mikenrafter commented 2 years ago

Possibly related to #78 and #70?