search

thedocruby / resounding

A New Minecraft mod that provides realistic audio physics using parallel wave tracing and an improved physics algorithm.
https://thedocruby.dev/resounding
GNU Lesser General Public License v3.0
85 stars 4 forks source link

Volume inconsistency for self-origin sounds #66

Open mio9 opened 2 years ago

mio9 commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Eating, drinking, or throwing snowballs in an anechoic environment (e.g. wooden/wool room/empty space)
  2. Observe its sound
  3. Perform the same action in a highly echoic environment (e.g. stone room/ large cuboid cave)
  4. Observe inconsistency in dry volume compared to step 2

Expected behavior In any circumstances, the dry (unprocessed, "unreverbed" sound) signal level should stay constant, and not to be scaled with the amount of reverb applied. Reverb and echo effects should be added on top of the original sound instead of scaling the original sound

Screenshots

image The first sound represents snowball throwing in a 6 blocks tall , 25 blocks radius cylindrical sandstone room The second sound represents snowball throwing in open sky at y=120 without any other blocks within 32 blocks range

image The throw in sandstone room peaks at -12dB on my system

image The throw in open sky peaks at -9db on my system

My Machine (please complete the following information):

Additional context Volume is fluctuating from location to location, but generally the muffling issue happens more in closed area than open area.

Crash Report/Logs N/A

mio9 commented 2 years ago

maybe related to #38 , but seems not just reverb, it affect the source sound as well

YurgenSchn commented 2 years ago

I think it is indeed related to #38. Such sounds are being absorbed, as if they were being played slightly underground or behind walls (noticeable with lower Absorption Brightness), and their reverbs are much quieter if not non-existant.

As far as I know, it happens just if you grounded, fly and it will be ok.

Footsteps used to be included on that, but he's fixed it exclusively. Doc has noted this issue tho.

mikenrafter commented 2 years ago

This is a very in-depth write-up, thank you. There are just so many versions of this same bug in the issue tracker. All with slightly different circumstances. So I'm marking this as a duplicate - as to prevent new issues from surfacing over this same problem.

Originally posted by @mikenrafter in https://github.com/thedocruby/resounding/issues/38#issuecomment-1183695614

^ Same reasoning as here.