Allow content and title to be use for the message

thedod / feed2twister

Simple cron script to post RSS/ATOM items to Twister

GNU General Public License v3.0

10 stars 4 forks source link

Allow content and title to be use for the message #3

Closed mrvdb closed 9 years ago

mrvdb commented 10 years ago

The content element contains the more interesting stuff, but may contain markup which we remove by using BeautifulSoup get_text() method.

A new configuration variable has been defined to choose between title and content. This should actually be possible per feed.

The calculation of the length of the message has been changed a bit to make it more readable.

This pull request depends on the earlier pull requests I made.

thedod commented 9 years ago

Allowing html injection attacks sounds risky to me. There might even be measures against html content at the twisterd and/or client level (at least there should be :wink:).

P.S. in the future - when you pull-request several features, best is to do each one as a separate branch (all checked out from master), and then have your own "production" branch that merges them all. This way the upstream maintainer has the freedom to decide which pull-requests to use and which not too.